regreet: respect dark mode and do not set extraCss #723
Conversation
Well, I guess I could trigger a warning that stylix may not style regreet correctly when regreet is misconfigured and can't get styled by global gtk. But that seems kind of common sense to me. Misconfigured meaning that there are custom values under |
Sadly, it might not be obvious to people just installing Stylix without digging into the source code. Adding a
That could be the condition of the |
Mikilio
force-pushed
the
fix-regreet
branch
2 times, most recently
from
186a69e to
747d75a
Compare
ReGreet will choose dark colors from the GTK theme if we instruct it to do so. ReGreet uses the global GTK theme if the environment is set the default Nixpkgs configuration takes care of that so extraCss will be left free for actual user overrides.
|
Successfully created backport PR for |
Respect the stylix.polarity option and unset programs.regreet.extraCss to enable custom styling. This partially resolves the "ReGreet not using GTK or cursor theme" [1] issue. [1]: #690 Link: #723 Reviewed-by: NAHO <[email protected]> (cherry picked from commit 5c84f02)
Respect the stylix.polarity option and unset programs.regreet.extraCss to enable custom styling. This partially resolves the "ReGreet not using GTK or cursor theme" [1] issue. [1]: #690 Link: #723 Reviewed-by: NAHO <[email protected]> (cherry picked from commit 5c84f02)
ReGreet will choose dark colors from the GTK theme if we instruct it to do so.
ReGreet uses the global GTK theme if the environment is set the default Nixpkgs configuration takes care of that so extraCss will be left free for actual user overrides.
For regreet to be themed correctly, users need to start regreet with dbus environment. Nixpkgs does this by default but I don't know how to help people with special configurations.
Motivated by #690